Rust Community · Open-sourced a rate-limiting middleware for Rust with token bucket and sliding window

432
Rsr/rust·posted by ran_bo·5 minutes agoPostmortem

Open-sourced a rate-limiting middleware for Rust with token bucket and sliding window

Some background first. Our setup is Rust plus three downstream services, seven figures of daily requests, peaking around nine in the evening.

The first thing was to collapse the variables. We were changing config and upgrading the version at the same time, and afterwards nobody could say which change caused what. We rolled back to moving one variable at a time, re-ran three times, and only then did the curve settle. Tedious, but not skippable.

On trade-offs, my view is this: if nobody on the team owns this area long-term, do not introduce a second mechanism. With two coexistence you first have to work out which one is even in play when things break, and that costs far more than the performance you saved.

Bblog.cloudflare.comExternal link · opens in a new tab
172 comments

172 comments

· first 120 loaded
M
Kkernel_panic·2 days ago

I just read the Rust source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

515
Lli_ming·2 days ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

196
Mmike_xu·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

513
Oops_wang·2 hours ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

271
Ddev_zhou·2 days ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

510
Oops_wang·12 minutes ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

494
Bbob_chen·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

487
Kkernel_panic·just now

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

386
Rrase·2 days ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

333
Kkernel_panic·2 days agoedited

One counter-example: below Rust 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

128
Kkernel_panic·2 days ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

25
Kkite·2 days ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

2
Sslow_query·just now

I just read the Rust source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

188
Wwinter·2 days ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

116
Ttang_hao·5 hours ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

63
Wwinter·2 days ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

277
Mmike_xu·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

47
WwinterOPMod·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

1
Nnikic·2 days ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

364
Sslow_query·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

342
RraseOP·2 days agoedited

This is not a Rust problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

218
Zzhou_yi·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

264
Sswoole_lee·3 minutes agoedited

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

168
Cchen_dev·2 days agoedited

One counter-example: below Rust 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

69
Aalice_dev·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

1
Kkite·12 minutes ago

This is not a Rust problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

2
Zzhou_yiOP·2 days ago

I just read the Rust source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

147
Hhuang_ke·2 days ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

2
Lli_mingOP·just now

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

37
Kkite·28 minutes agoedited

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

248
Nnikic·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

236
Rran_bo·2 days ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

226
Bbob_chen·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

213
Kkernel_panic·2 days agoedited

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

485
Zzhou_yi·2 days ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

318
Lli_ming·2 days agoedited

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

2
Wwinter·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

3
Bbob_chen·2 days ago

One counter-example: below Rust 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

198
Kkite·2 days ago

One counter-example: below Rust 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

197
KkiteOP·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

120
Rrase·2 days ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

182
Oops_wang·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

179
Kkernel_panic·2 days ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

158
Hhuang_ke·2 days ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

444
Llinlin·2 days ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

54
Zzhu_zong·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

155
RraseOP·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

93
Sslow_query·28 minutes ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

152
Kkernel_panic·2 days ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

152
Sswoole_lee·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

150
Zzhu_zong·28 minutes ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

210
Wwinter·2 days ago

This is not a Rust problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

149
Zzhou_yi·3 minutes ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

130
Oops_wang·2 hours ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

447
Oops_wang·3 minutes ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

151
Oops_wang·3 minutes ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

347
Mmike_xuOP·3 minutes ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

322
Aalice_devMod·2 days ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

486
Sswoole_leeOP·12 minutes agoedited

Saved. I am reworking this area this week — this saves a lot of wrong turns.

409
Aalice_dev·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

114
Ddev_zhouOP·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

295
Sswoole_leeOP·2 days ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

283
Rran_bo·2 days ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

2
Kkernel_panicMod·2 days ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

81
Oops_wang·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

439
Rran_boOP·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

2
Ddev_zhou·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

35
Lli_ming·5 hours ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

426
Llinlin·28 minutes ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

1
Hhuang_ke·2 days agoedited

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

12
Zzhu_zong·yesterday

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

2
Llinlin·2 days ago

I just read the Rust source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

395
Cchen_dev·2 days ago

I just read the Rust source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

510
Llinlin·2 days agoLevel 6

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

296
KkiteOP·1 hour agoLevel 6

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

16
Zzhu_zong·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

287
Ddev_zhou·2 days agoLevel 6

One counter-example: below Rust 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

11
Oops_wang·2 days agoLevel 6

One counter-example: below Rust 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

1
Wwinter·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

312
Wwinter·2 days ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

38
Rrase·2 days ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

238
Wwinter·just now

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

8
Rran_bo·2 days agoedited

Saved. I am reworking this area this week — this saves a lot of wrong turns.

99
Rrase·2 days ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

76
Mmike_xu·12 minutes ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

71
Nnikic·just now

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

387
Zzhou_yi·just now

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

1
Sswoole_lee·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

60
Bbob_chen·12 minutes ago

This is not a Rust problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

2
Zzhu_zong·2 days agoLevel 6

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

361
Mmike_xuOP·2 days agoLevel 6

I just read the Rust source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

6
Llinlin·2 days agoLevel 6

This is not a Rust problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

7
Zzhu_zong·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

71
Rran_boOP·5 hours ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

1
Kkernel_panicOP·2 days ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

1
Hhuang_ke·1 hour ago

This is not a Rust problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

46
Sswoole_lee·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

44
Lli_ming·2 days ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

36
Cchen_dev·just now

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

29
Kkernel_panic·28 minutes ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

190
Llinlin·just nowedited

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

17
Zzhu_zong·12 minutes ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

262
Wwinter·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

193
Bbob_chen·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

8
Kkite·28 minutes ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

16
Llinlin·3 minutes ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

6
Cchen_dev·2 days ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

5
Kkernel_panic·2 days ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

4
Sslow_query·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

2
Mmike_xu·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

246
Kkite·2 days ago

This is not a Rust problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

2
Hhuang_ke·2 days ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

2
Nnikic·28 minutes ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

1
Sslow_query·5 hours ago

One counter-example: below Rust 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

43
NnikicOP·28 minutes ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

1
Rran_bo·2 days ago

I just read the Rust source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

145
Lli_ming·2 days ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

4
Ddev_zhouMod·2 days ago

This is not a Rust problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

1
Sswoole_lee·2 days ago

One counter-example: below Rust 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

1
Kkernel_panic·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

1

This is the post detail page /en/c/rust/post/p13. Posts and comments are generated deterministically from a seeded PRNG, so the same post always renders the same content and the link can be shared, reloaded and indexed. In production this page reads MySQL for the post, Redis for hot-post caching, and fetches the whole comment tree in a single query on the path column.

See the database schema →