HLSL · Performance · Ten hlsl-perf anti-patterns — how many are you guilty of?

92
HLr/hlsl-perf·posted by huang_ke·2 days agoOpen source

Ten hlsl-perf anti-patterns — how many are you guilty of?

Short version: hlsl-perf needs almost no tuning at small and medium scale — the point where it starts to hurt is much further out than most people assume. Full measurements below.

What genuinely surprised me was the tail. The average looked great while P99 jumped by an order of magnitude past some threshold. The cause was not hlsl-perf itself but our upstream connection reuse — the load test traffic was too clean and hid the long-tail requests.

Worth noting: the official docs do cover this, just in a very inconspicuous spot. I only found it reading the source comments, where the author explains the reasoning — roughly "so that it degrades into predictable behaviour in extreme cases".

The first thing was to collapse the variables. We were changing config and upgrading the version at the same time, and afterwards nobody could say which change caused what. We rolled back to moving one variable at a time, re-ran three times, and only then did the curve settle. Tedious, but not skippable.

We also fixed monitoring along the way: replaced average-based alerts with percentiles and split them per endpoint. False alerts dropped by about seventy percent and the on-call rotation visibly cheered up.

39 comments

39 comments

M
Bbob_chen·12 minutes ago

One counter-example: below hlsl-perf 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

471
Zzhu_zong·5 hours ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

417
Lli_ming·2 days ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

3
Ddev_zhouMod·2 days ago

This is not a hlsl-perf problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

462
Ddev_zhou·2 days ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

21
Cchen_dev·3 minutes agoedited

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

426
Kkernel_panicOP·2 hours ago

This is not a hlsl-perf problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

21
Zzhu_zong·12 minutes ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

156
Zzhou_yi·yesterday

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

407
Rrase·2 days ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

403
Oops_wang·2 days ago

I just read the hlsl-perf source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

355
Wwinter·just now

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

244
Zzhou_yi·3 minutes ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

294
Ddev_zhou·1 hour ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

22
Bbob_chen·3 minutes ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

246
Bbob_chen·5 hours agoedited

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

34
Zzhou_yi·2 days ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

1
LlinlinOP·just nowedited

This is not a hlsl-perf problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

33
Sslow_query·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

122
Aalice_dev·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

36
Llinlin·2 days ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

92
Bbob_chen·2 hours ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

68
Ddev_zhouOP·2 days ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

3
Hhuang_ke·2 days ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

326
Sslow_queryOP·2 days agoedited

One counter-example: below hlsl-perf 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

1
LlinlinOP·2 days ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

1
Kkite·3 minutes ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

47
Mmike_xu·2 days ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

170
Hhuang_ke·2 days ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

159
Zzhou_yi·28 minutes agoedited

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

22
Nnikic·5 hours ago

I just read the hlsl-perf source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

430
Aalice_devMod·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

84
Ddev_zhou·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

5
Sswoole_lee·2 days ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

3
Aalice_dev·12 minutes agoedited

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

1
Ddev_zhou·28 minutes ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

7
Lli_ming·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

1
Zzhu_zong·2 days ago

I just read the hlsl-perf source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

1
Wwinter·2 days ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

1

This is the post detail page /en/c/hlsl-perf/post/p4. Posts and comments are generated deterministically from a seeded PRNG, so the same post always renders the same content and the link can be shared, reloaded and indexed. In production this page reads MySQL for the post, Redis for hot-post caching, and fetches the whole comment tree in a single query on the path column.

See the database schema →