Baking · Events · Ten baking-events anti-patterns — how many are you guilty of?

177
BAr/baking-events·posted by winter·3 hours agoReview

Ten baking-events anti-patterns — how many are you guilty of?

Some background first. Our setup is baking-events plus three downstream services, seven figures of daily requests, peaking around nine in the evening.

The first thing was to collapse the variables. We were changing config and upgrading the version at the same time, and afterwards nobody could say which change caused what. We rolled back to moving one variable at a time, re-ran three times, and only then did the curve settle. Tedious, but not skippable.

What genuinely surprised me was the tail. The average looked great while P99 jumped by an order of magnitude past some threshold. The cause was not baking-events itself but our upstream connection reuse — the load test traffic was too clean and hid the long-tail requests.

We also fixed monitoring along the way: replaced average-based alerts with percentiles and split them per endpoint. False alerts dropped by about seventy percent and the on-call rotation visibly cheered up.

On trade-offs, my view is this: if nobody on the team owns this area long-term, do not introduce a second mechanism. With two coexistence you first have to work out which one is even in play when things break, and that costs far more than the performance you saved.

59 comments

59 comments

M
Llinlin·2 days ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

478
Cchen_dev·2 days ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

377
Kkernel_panic·2 days agoedited

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

364
Sswoole_lee·3 minutes agoedited

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

361
Sswoole_leeOP·just now

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

497
Wwinter·yesterday

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

334
Kkite·2 days ago

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

33
Zzhu_zong·1 hour ago

This is not a baking-events problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

309
Ddev_zhouOP·2 days agoedited

This is not a baking-events problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

2
Mmike_xu·2 days ago

One counter-example: below baking-events 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

1
Zzhou_yi·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

290
Sslow_queryOP·2 days ago

One counter-example: below baking-events 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

142
Ddev_zhou·2 days ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

154
Rrase·12 minutes ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

148
Ttang_hao·2 days ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

122
Kkite·3 minutes ago

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

107
Mmike_xu·12 minutes agoedited

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

104
Sswoole_lee·2 days agoedited

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

329
Oops_wang·2 days ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

96
Aalice_dev·1 hour agoedited

One counter-example: below baking-events 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

79
Oops_wang·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

55
Kkite·5 hours ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

292
Sslow_queryOP·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

1
Sslow_query·just now

I just read the baking-events source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

368
Kkernel_panic·2 hours ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

60
Nnikic·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

19
Wwinter·2 days ago

This is not a baking-events problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

52
Zzhu_zong·28 minutes ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

47
Sslow_query·1 hour agoedited

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

394
Aalice_dev·2 hours ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

124
Aalice_dev·12 minutes ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

42
Bbob_chen·28 minutes agoedited

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

33
Rran_bo·just nowedited

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

424
Oops_wangOP·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

136
Kkernel_panic·2 days ago

I just read the baking-events source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

26
Wwinter·just now

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

15
Ttang_hao·28 minutes ago

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

406
Zzhu_zong·3 minutes ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

18
Ttang_hao·5 hours ago

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

1
Bbob_chen·2 days ago

We have run this in production for two years without hitting it. That said, we never reached this scale, so our experience is not really evidence here.

163
Ddev_zhou·2 days ago

One counter-example: below baking-events 7.4 the semantics of that code are different, so do not copy it verbatim. We got burned in staging and rolled back once.

417
Kkernel_panic·2 days agoLevel 6

I just read the baking-events source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

369
Cchen_dev·2 days ago

Has anyone run a controlled experiment? I did, reducing it to a single variable, and the difference was 4% — within noise. So I suspect the main cause is something else.

15
Nnikic·2 days ago

I see point 3 differently. The trade-off depends on your read/write ratio: read-heavy with little writing means caching actually widens the inconsistency window.

159
Wwinter·just now

Thanks for sharing real numbers — far more useful than the articles that only cover concepts.

267
Sswoole_leeMod·28 minutes ago

Agreeing with the above. One addition: with this option enabled the GC count in your metrics doubles, so adjust the alert threshold at the same time or it will keep firing.

10
Bbob_chen·12 minutes ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

8
Bbob_chen·1 hour ago

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

3
Oops_wang·28 minutes agoedited

Sharing our numbers, 8 cores 16GB, same scenario:

| Concurrency | P50 | P99 |
|---|---|---|
| 200 | 12ms | 88ms |
| 500 | 31ms | 340ms |

P99 clearly collapses at 500 concurrency, which lines up with your knee point.

3
Zzhu_zong·just now

Can you give a minimal reproduction? I ran it locally for ten minutes and could not reproduce on macOS with the latest version.

2
Nnikic·2 days ago

There is actually a simpler fix that needs no architecture change: move this check up to the gateway and the problem disappears. The cost is one extra lookup at the gateway.

2
Zzhou_yi·2 days ago

This is not a baking-events problem, it is a usage problem. The docs say this API is not thread-safe and you must lock around it yourself.

2
Kkite·28 minutes ago

I just read the baking-events source — the author actually explains the reasoning in a comment, roughly "so that it degrades into predictable behaviour in extreme cases".

1
Zzhou_yi·1 hour ago

A question: what changes in a container with a 512Mi memory limit? That is how we run it in production.

232
RraseOP·2 days ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

65
Wwinter·2 days ago

Saved. I am reworking this area this week — this saves a lot of wrong turns.

34
Rrase·2 days agoedited

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

1
Rran_bo·5 hours agoedited

This matches what we see in production. We only hit it past 3k QPS; the earlier load tests showed nothing — the test traffic was too clean, with no long-tail requests.

1
Bbob_chen·yesterday

Worth learning from this debugging approach. We went straight at the logs and took a much longer route.

481

This is the post detail page /en/c/baking-events/post/p11. Posts and comments are generated deterministically from a seeded PRNG, so the same post always renders the same content and the link can be shared, reloaded and indexed. In production this page reads MySQL for the post, Redis for hot-post caching, and fetches the whole comment tree in a single query on the path column.

See the database schema →